From: Karthik Nayak Date: Mon, 08 Jun 2015 17:13:25 GMT Subject: Re: [PATCH v6 09/11] ref-filter: move code from 'for-each-ref' Message-ID: <5575CD35.4030705@gmail.com> In-Reply-To: On 06/08/2015 10:38 PM, Matthieu Moy wrote: > Karthik Nayak writes: > > > --- a/builtin/for-each-ref.c > > +++ b/builtin/for-each-ref.c > > @@ -1129,7 +56,7 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix) > > > > memset(&ref_cbdata, 0, sizeof(ref_cbdata)); > > ref_cbdata.filter.name_patterns = argv; > > - for_each_rawref(ref_filter_handler, &ref_cbdata); > > + filter_refs(for_each_rawref, &ref_cbdata); > > This seems unrelated from the rest of the patch. And you haven't > introduced filter_refs yet! > That definitely is, this happened after fixing merges I suppose. Ignore it for now, I'll fix it. -- Regards, Karthik