From: Karthik Nayak Date: Sun, 31 May 2015 09:17:38 GMT Subject: Re: [WIP/PATCH v4 6/8] for-each-ref: rename some functions and make them public Message-ID: <556AD1B2.3080502@gmail.com> In-Reply-To: On 05/31/2015 01:41 PM, Christian Couder wrote: > On Sun, May 31, 2015 at 10:04 AM, Christian Couder > wrote: >> On Sat, May 30, 2015 at 7:53 PM, Karthik Nayak wrote: >>> >>> -static void sort_refs(struct ref_sort *sort, struct ref_array *array) >>> +void sort_ref_array(struct ref_sort *sort, struct ref_array *array) >> >> It is probably better to call the above function ref_array_sort()... >> >> [...] >> >>> -static struct ref_sort *default_sort(void) >>> +/* If no sorting option is given, use refname to sort as default */ >>> +struct ref_sort *ref_default_sort(void) >> >> ... especially since you call the above ref_default_sort()... >> >>> -static int opt_parse_sort(const struct option *opt, const char *arg, int unset) >>> +int opt_parse_ref_sort(const struct option *opt, const char *arg, int unset) >> >> ... and the above opt_parse_sort(). > > After saying that I realize that these two other functions are not > doing the same thing. > This might suggest that they are not named very well as well. > What do you mean by "not doing the same thing." -- Regards, Karthik