From: Karthik Nayak <karthik.188@gmail.com>
Date: Sun, 31 May 2015 08:16:34 GMT
Subject: Re: [WIP/PATCH v4 6/8] for-each-ref: rename some functions and make them public
Message-ID: <556AC362.80805@gmail.com>
In-Reply-To: <CAPig+cTyy5ai0O4BAG+3+_6x-8OC5SoUDR=swCq-bNFP3DfxUg@mail.gmail.com>

On 05/31/2015 08:51 AM, Eric Sunshine wrote:
> On Sat, May 30, 2015 at 1:53 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> Rename some of the functions and make them publically available.
>
> s/publically/publicly/
>
>> This is a preparatory step for moving code from 'for-each-ref'
>> to 'ref-filter' to make meaningful, targeted services available to
>> other commands via public APIs.
>>
>> Based-on-patch-by: Jeff King <peff@peff.net>
>> Mentored-by: Christian Couder <christian.couder@gmail.com>
>> Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
>> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
>> ---
>> diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
>> index f896e1c..8fed04b 100644
>> --- a/builtin/for-each-ref.c
>> +++ b/builtin/for-each-ref.c
>> @@ -882,10 +882,10 @@ static struct ref_array_item *new_ref_array_item(const char *refname,
>>   }
>>
>>   /*
>> - * A call-back given to for_each_ref().  Filter refs and keep them for
>> + * A call-back given to for_each_ref(). Filter refs and keep them for
>
> Sneaking in whitespace change?
>
>>    * later object processing.
>>    */
>> -static int grab_single_ref(const char *refname, const unsigned char *sha1, int flag, void *cb_data)
>> +int ref_filter_handler(const char *refname, const unsigned char *sha1, int flag, void *cb_data)
>>   {
>>          struct ref_filter_cbdata *ref_cbdata = cb_data;
>>          struct ref_filter *filter = &ref_cbdata->filter;


Noted. Will fix!

-- 
Regards,
Karthik