From: karthik nayak <karthik.188@gmail.com>
Date: Thu, 21 May 2015 06:27:58 GMT
Subject: Re: [PATCH 1/4] for-each-ref: rename refinfo members to match similar structures
Message-ID: <555D7AEE.7080201@gmail.com>
In-Reply-To: <vpqtwv7qj92.fsf@anie.imag.fr>



On 05/20/2015 10:27 PM, Matthieu Moy wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> From: Jeff King <peff@peff.net>
>
> This means that "git am" will consider Peff as the author ...
>
>> Written-by: Jeff King <peff@peff.net>
>
> ... hence this is not needed: in the final history, it will appear as if
> Peff wrote this Written-by: himself, which would be weird.
>
> If it is the case, you should add in the commit message that there's no
> actual changs, and perhaps which renames were done. This makes the
> review straightforward.
>

Noted, will change it.