From: Torsten Bögershausen <tboegi@web.de>
Date: Mon, 23 Mar 2015 05:14:24 GMT
Subject: Re: [PATCH 4/5] Add tests for git-log --merges=show|hide|only
Message-ID: <550FA130.1030402@web.de>
In-Reply-To: <550F450F.6070207@posteo.de>

Back to the original discussion:

+test_expect_success 'log with config log.merges=show' '
+    git config log.merges show &&
+    git log --pretty=tformat:%s >actual &&
+    test_cmp both_commits_merges actual &&
+    git config --unset log.merges

These days I would probably shorten the code, the review time and
the execution time of the test and increase the clean-ness with 50%
by simply writing

+test_expect_success 'log with config log.merges=show' '
+	git -c log.merges=show log --pretty=tformat:%s >actual &&
+	test_cmp both_commits_merges actual
+	'