From: Torsten Bögershausen <tboegi@web.de>
Date: Mon, 23 Feb 2015 05:36:40 GMT
Subject: Re: [PATCH v2 2/3] t5601: add more test cases for IPV6
Message-ID: <54EABC68.40308@web.de>
In-Reply-To: <xmqq61atuysn.fsf@gitster.dls.corp.google.com>

On 02/23/2015 03:50 AM, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> @@ -359,7 +366,7 @@ done
>>   for repo in rep rep/home/project 123
>>   do
>>   	test_expect_success "clone [::1]:$repo" '
>> -		test_clone_url [::1]:$repo ::1 $repo
>> +		test_clone_url [::1]:$repo ::1 "$repo"
>>   	'
>>   done
> This change is somewhat a curious one.  Why quote the last
> occurrence of $repo but not the previous one?
The reason to quote is that
some shells replace ~ with $HOME, but not "~"
exactly here it seems not to be needed.
>
>> +for tuah in ::1 [::1] user@::1 user@[::1] [user@::1]
>> +do
>> +	euah=$(echo $tuah | tr -d "[]")
> What are tuah and euah, by the way?  Are they FLA for some phrases?
tuah = tested username and host
euah = expected username and host