From: René Scharfe <l.s.r@web.de>
Date: Sun, 22 Feb 2015 22:33:16 GMT
Subject: Re: [PATCH] sha1_name: use strlcpy() to copy strings
Message-ID: <54EA592C.6040701@web.de>
In-Reply-To: <xmqqsidxvhrk.fsf@gitster.dls.corp.google.com>

Am 22.02.2015 um 21:00 schrieb Junio C Hamano:
> René Scharfe <l.s.r@web.de> writes:
>
>> Use strlcpy() instead of calling strncpy() and then setting the last
>> byte of the target buffer to NUL explicitly.  This shortens and
>> simplifies the code a bit.
>
> Thanks.  It makes me wonder if the longer term direction should be
> not to use a bound buffer for oc->path, though.

That's a good idea in general, but a bit more involved since we'd need 
to introduce a cleanup function that releases the memory allocated by 
the new version of get_sha1_with_context() first and call it from the 
appropriate places.

Would that be a good micro-project for GSoC or is it too simple?

René