From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Fri, 13 Feb 2015 14:34:42 GMT
Subject: Re: [PATCH 6/8] reflog_expire(): ignore --updateref for symbolic references
Message-ID: <54DE0B82.6090906@alum.mit.edu>
In-Reply-To: <20150212215421.GA19618@peff.net>

On 02/12/2015 10:54 PM, Jeff King wrote:
> On Mon, Feb 09, 2015 at 10:12:42AM +0100, Michael Haggerty wrote:
> 
>>  	if (!(flags & EXPIRE_REFLOGS_DRY_RUN)) {
>> +		/*
>> +		 * It doesn't make sense to adjust a reference pointed
>> +		 * to by a symbolic ref based on expiring entries in
>> +		 * the symbolic reference's reflog.
>> +		 */
>> +		int update = (flags & EXPIRE_REFLOGS_UPDATE_REF) &&
>> +			~(type & REF_ISSYMREF);
>> +
> 
> Isn't this second clause tautological? Unless REF_ISSYMREF covers all
> bits in "type", then "type & REF_ISSYMREF" must always have at least one
> bit 0, and negating it becomes non-zero. Did you mean:
> 
>    !(type & REF_ISSYMREF)
> 
> ?

You're right, of course. Thanks.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu