From: Ramsay Jones Date: Fri, 19 Dec 2014 17:24:56 GMT Subject: [PATCH] refs.c: remove extern keyword from function definition Message-ID: <54945F68.9000807@ramsay1.demon.co.uk> Commit 5ed85684 ("reflog_expire(): new function in the reference API", 12-12-2014) added a new function definition which included the extern keyword. While this is not an illegal use of the keyword, it is somewhat unusual to include it in a function definition. (It would be unique in the git codebase). Also, it triggers a warning from sparse. In order to suppress the warning, simply remove the extern keyword from reflog_expire() definition. Signed-off-by: Ramsay Jones --- Hi Michael, If you need to re-roll your 'mh/reflog-expire' series, could you please squash this into the relevant patch. Thanks! ATB, Ramsay Jones refs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/refs.c b/refs.c index 3bd686c..fdef36d 100644 --- a/refs.c +++ b/refs.c @@ -4020,12 +4020,12 @@ static int expire_reflog_ent(unsigned char *osha1, unsigned char *nsha1, return 0; } -extern int reflog_expire(const char *refname, const unsigned char *sha1, - unsigned int flags, - reflog_expiry_prepare_fn prepare_fn, - reflog_expiry_should_prune_fn should_prune_fn, - reflog_expiry_cleanup_fn cleanup_fn, - void *policy_cb_data) +int reflog_expire(const char *refname, const unsigned char *sha1, + unsigned int flags, + reflog_expiry_prepare_fn prepare_fn, + reflog_expiry_should_prune_fn should_prune_fn, + reflog_expiry_cleanup_fn cleanup_fn, + void *policy_cb_data) { static struct lock_file reflog_lock; struct expire_reflog_cb cb; -- 2.2.0