From: Johannes Sixt Date: Tue, 09 Dec 2014 20:14:29 GMT Subject: Re: [PATCH 4/7] parse_color: refactor color storage Message-ID: <54875825.7060008@kdbg.org> In-Reply-To: <20141120151704.GD23680@peff.net> Am 20.11.2014 um 16:17 schrieb Jeff King: > +#define COLOR_FOREGROUND '3' > +#define COLOR_BACKGROUND '4' This (COLOR_BACKGROUND) causes an ugly redefinition warning on Windows, because we inherit a definition from a Windows header. How would you like it fixed? A different name or #undef in front of it? -- Hannes