From: Torsten Bögershausen <tboegi@web.de>
Date: Sun, 07 Dec 2014 08:00:12 GMT
Subject: Re: [PATCH] git-svn: Support for git-svn propset
Message-ID: <5484090C.8070101@web.de>
In-Reply-To: <5483E968.6060708@web.de>

On 2014-12-07 06.45, Torsten Bögershausen wrote:
[]
>> +
>> +test_expect_success 'add multiple props' '
>> +	git svn propset svn:keywords "FreeBSD=%H" foo &&
>> +	git svn propset fbsd:nokeywords yes foo &&
>> +	echo hello >> foo &&
>> +	git commit -m "testing propset" foo &&
>> +	git svn dcommit
>> +	svn_cmd co "$svnrepo" svn_project &&
>> +	(cd svn_project && test "`svn propget svn:keywords foo`" = "FreeBSD=%H") &&
>> +	(cd svn_project && test "`svn propget fbsd:nokeywords foo`" = "yes") &&
>> +	(cd svn_project && test "`svn proplist -q foo | wc -l`" -eq 2) &&
>> +	rm -rf svn_project
>> +	'
>> +
> Ah, another small thing:
> the "wc -l" will not work under Mac OS X.
> Please see test_line_count() in t/test-lib-functions.sh
> 
My excuse:
I think I am wrong here and I need to correct myself after having looked at other TC's.
The "wc -l" should work under Mac OS X.

Another small nit:

This 
"`svn propget svn:keywords foo`" = "FreeBSD=%H")
can be written as
"$(svn propget svn:keywords foo)" = "FreeBSD=%H")

(if you want to use the "Git style" for command substitution)