From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Tue, 09 Sep 2025 06:25:29 GMT
Subject: Re: [PATCH v3 3/8] git: allow alias-shadowing deprecated builtins
Message-ID: <54833b28-658f-4eec-93a6-74db11c4b9e4@app.fastmail.com>
In-Reply-To: <xmqq348wwqwb.fsf@gitster.g>

On Mon, Sep 8, 2025, at 23:55, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
>> cmd_struct were not the right spots. OTOH, it would probably not be that
>> hard to just do:
>>
>>   static int is_deprecated_command(const char *cmd)
>>   {
>> 	struct cmd_struct *builtin = get_builtin(cmd);
>> 	return builtin && (builtin->flags & DEPRECATED);
>>
>>   }
>
> That was exactly what I had in mind.

Thanks to both.  I’ll use that suggestion.

-- 
Kristoffer Haugsbakk