From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Sun, 01 Jan 2017 08:45:42 GMT
Subject: Re: [PATCH v3 11/23] log_ref_setup(): separate code for create vs non-create
Message-ID: <544457a2-5226-feea-1a32-74dd58233df8@alum.mit.edu>
In-Reply-To: <xmqqful34fww.fsf@gitster.mtv.corp.google.com>

On 01/01/2017 04:28 AM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>> +			if (errno == ENOENT || errno == EISDIR) {
>> +				/*
>> +				 * The logfile doesn't already exist,
>> +				 * but that is not an error; it only
>> +				 * means that we won't write log
>> +				 * entries to it.
>> +				 */
>> +			} else {
> 
> It may be valid C, but an
> 
> 	{
> 		/*
> 		 * an empty block without any statement,
> 		 * not even a null statement.
> 		 */
> 	}
> 
> always makes me a bit nervous.  Have a line with a semicolon without
> anything else (other than the indent) at the end and it will read
> nicer, at least to me.

That's a form of superstition that I haven't encountered before ;-) but
I'll change it.

Michael