From: Tanay Abhra <tanayabh@gmail.com>
Date: Thu, 24 Jul 2014 15:59:18 GMT
Subject: Re: [PATCH 0/7] Rewrite `git_config()` using config-set API
Message-ID: <53D12D56.2080505@gmail.com>
In-Reply-To: <vpq1ttadauu.fsf@anie.imag.fr>



On 7/24/2014 9:09 PM, Matthieu Moy wrote:
> Tanay Abhra <tanayabh@gmail.com> writes:
> 
>> I am attaching the v12 with two new functions git_configset_get_string() &
>> git_configset_get_string_const().
> 
> Didn't you intend to change git_config_get_string to let it die in case
> of error instead of returning an error code?
>

Yup, but it is the part of the new series not the old one.
I sent this revised patch just for solving the constness
debate.
Also, I would need git_die_config() to print a proper
error message which comes in the 7 part series not this one.