From: Tanay Abhra <tanayabh@gmail.com>
Date: Thu, 24 Jul 2014 13:56:07 GMT
Subject: Re: [PATCH 3/7] add a test for semantic errors in config files
Message-ID: <53D11077.10907@gmail.com>
In-Reply-To: <xmqq38drd8ue.fsf@gitster.dls.corp.google.com>



On 7/24/2014 3:41 AM, Junio C Hamano wrote:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> 
>> Tanay Abhra <tanayabh@gmail.com> writes:
>>
>>> +test_expect_success 'check line errors for malformed values' '
>>> +	cp .git/config .git/config.old &&
> 
> Should this be "mv" not "cp"?  You will be overwriting the file from
> scratch in the later part of this test.
>

Noted.

>>> +	test_when_finished "mv .git/config.old .git/config" &&
>>> +	echo "[alias]\n br" >.git/config &&
> 
> Is the use of \n portable?
> 

Yes, you are right, will replace with printf in the next patch.