From: Tanay Abhra <tanayabh@gmail.com>
Date: Thu, 24 Jul 2014 13:33:43 GMT
Subject: Re: [PATCH 1/7] config.c: fix accuracy of line number in errors
Message-ID: <53D10B37.3000403@gmail.com>
In-Reply-To: <xmqqegxbd9u0.fsf@gitster.dls.corp.google.com>



On 7/24/2014 3:19 AM, Junio C Hamano wrote:
> Tanay Abhra <tanayabh@gmail.com> writes:
> 
>> If a callback returns a negative value to `git_config*()` family,
>> they call `die()` while printing the line number and the file name.
>> Currently the printed line number is off by one, thus printing the
>> wrong line number.
>>
>> Make `linenr` point to the line we just parsed during the call
>> to callback to get accurate line number in error messages.
>>
>> Discovered-by: Tanay Abhra <tanayabh@gmail.com>
>> Signed-off-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
> 
> Thanks.
> 
> I am not sure what to read in these two lines.  Was the fix done by
> you or Matthieu?
>

I misunderstood the meaning of the message trailers. I will correct
it in the next re roll.