From: Tanay Abhra <tanayabh@gmail.com>
Date: Tue, 22 Jul 2014 11:48:38 GMT
Subject: Re: [PATCH] config.c: change the function signature of `git_config_string()`
Message-ID: <53CE4F96.3000409@gmail.com>
In-Reply-To: <vpqsiltsjm7.fsf@anie.imag.fr>



On 7/22/2014 5:14 PM, Matthieu Moy wrote:
> Jeff King <peff@peff.net> writes:
> 
>> will complain that we are passing a pointer to "const char *", not a
>> pointer to "char *". And indeed, compiling with your patch introduces a
>> ton of compiler warnings.
> 
> Tanay: are you not compiling with gcc -Wall -Werror?
> 
> (see my earlier message, just create a file config.mak containing
> 
>   CFLAGS += -Wdeclaration-after-statement -Wall -Werror
> 
> )
>

Yes, I was. Dunno why it didn't work then.