From: Tanay Abhra <tanayabh@gmail.com>
Date: Mon, 21 Jul 2014 14:23:47 GMT
Subject: Re: [PATCH/RFC] rewrite `git_default_config()` using config-set API functions
Message-ID: <53CD2273.3000600@gmail.com>
In-Reply-To: <vpqha2addyn.fsf@anie.imag.fr>


> 
>> +	if > +	git_config_get_string("core.notesref", (const char**)&notes_ref_name);
> 
> This cast is needed only because notes_ref_name is declared as
> non-const, but a better fix would be to make the variable const, and
> remove the cast.

Same casts had to be used in imap-send.c patch, I will have to use an
intermediate variable there to remove the cast thus destroying the one
liners or will have to update the variable declarations.