From: Karsten Blees Date: Thu, 17 Jul 2014 19:24:17 GMT Subject: Re: [PATCH 00/13] mingw unicode environment Message-ID: <53C822E1.9020003@gmail.com> In-Reply-To: <20140717190000.GA18960@ucw.cz> Am 17.07.2014 21:00, schrieb Stepan Kasal: > Hi, > >> Karsten Blees writes: >>> I believe we prefer moving code to the right place over forward >>> declarations (IIRC I got bashed for the latter in one of the first rounds >>> of this patch series). If only to justify 'git-blame -M' :-D > > indeed, my position is the same, generally. > > But it turned out that the current ordering is sane, mostly works as it is, > and I needed _only one_ fwd decl to make things compile. This is why I > decided to have things arranged this way. > Fine with me. However, if it *did* compile for you, I wonder where ALLOC_GROW (as of #02/13) and alloc_nr (as of #10/13) came from? Or did we recently remove '#include "cache.h"' from upstream mingw.c? -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.