From: Tanay Abhra <tanayabh@gmail.com>
Date: Wed, 09 Jul 2014 11:15:08 GMT
Subject: Re: [PATCH v6 2/2] test-config: Add tests for the config_set API
Message-ID: <53BD243C.6010907@gmail.com>
In-Reply-To: <vpqvbr9w154.fsf@anie.imag.fr>



On 7/7/2014 10:34 PM, Matthieu Moy wrote:
> Tanay Abhra <tanayabh@gmail.com> writes:
> 
>> diff --git a/t/t1308-config-hash.sh b/t/t1308-config-hash.sh
>> new file mode 100755
>> index 0000000..ad99f8b
>> --- /dev/null
>> +++ b/t/t1308-config-hash.sh
>> +test_expect_success 'setup default config' '
>> +	cat >.git/config << EOF
> 
> Missing && here (sorry, I should have noticed the first time).
> 

Does a single cat command warrant a `&&`? It errors out when I try
to add it there.