From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Tue, 08 Jul 2014 11:47:41 GMT
Subject: Re: [PATCH v20 07/48] lockfile.c: make lock_file return a meaningful errno on failurei
Message-ID: <53BBDA5D.7090608@alum.mit.edu>
In-Reply-To: <1403275409-28173-8-git-send-email-sahlberg@google.com>

On 06/20/2014 04:42 PM, Ronnie Sahlberg wrote:
> Making errno when returning from lock_file() meaningful, which should
> fix
> 
>  * an existing almost-bug in lock_ref_sha1_basic where it assumes
>    errno==ENOENT is meaningful and could waste some work on retries
> 
>  * an existing bug in repack_without_refs where it prints
>    strerror(errno) and picks advice based on errno, despite errno
>    potentially being zero and potentially having been clobbered by
>    that point
> [...]

Typo in subject line:

s/failurei/failure/

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu