From: Avi Kivity <avi@cloudius-systems.com>
Date: Thu, 03 Jul 2014 14:08:33 GMT
Subject: Re: [PATCH v2] git-am: add option to extract email Message-Id: tag into commit log
Message-ID: <53B563E1.8080201@cloudius-systems.com>
In-Reply-To: <xmqq1tu3isti.fsf@gitster.dls.corp.google.com>


On 07/02/2014 08:17 PM, Junio C Hamano wrote:
> Avi Kivity <avi@cloudius-systems.com> writes:
>
>> +		if test 't' == "$message_id"
>> +		then
>> +			grep ^Message-Id: "$dotest/info" || true
>> +		fi
>>   		if test '' != "$ADD_SIGNOFF"
>>   		then
>>   			echo "$ADD_SIGNOFF"
> Seeing how existing code carefully makes sure that ADD_SIGNOFF has
> an empty line before it when and only when necessary to ensure that
> there is a blank after the existing log message, I would suspect
> that this patch that blindly inserts a line is doubly wrong.  The
> output from "grep" may be appended without adding a blank when
> necessary, and appending of ADD_SIGNOFF may end up adding an extra
> blank after Message-Id.  Am I reading the patch wrong?

Yes, you're right.  Will have to redo the logic for deciding whether we 
already have a tag stanza or not.