From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Wed, 18 Jun 2014 20:47:52 GMT
Subject: Re: [PATCH v18 16/48] refs.c: add an err argument to delete_ref_loose
Message-ID: <53A1FAF8.4050700@alum.mit.edu>
In-Reply-To: <1403020442-31049-17-git-send-email-sahlberg@google.com>

On 06/17/2014 05:53 PM, Ronnie Sahlberg wrote:
> Add an err argument to delete_loose_ref so that we can pass a descriptive
> error string back to the caller. Pass the err argument from transaction
> commit to this function so that transaction users will have a nice error
> string if the transaction failed due to delete_loose_ref.
> 
> Add a new function unlink_or_err that we can call from delete_ref_loose. This
> function is similar to unlink_or_warn except that we can pass it an err
> argument. If err is non-NULL the function will populate err instead of
> printing a warning().
> 
> Simplify warn_if_unremovable.
> [...]

I'm getting test failures starting with this commit:

> Test Summary Report
> -------------------
> t5514-fetch-multiple.sh                          (Wstat: 256 Tests: 11 Failed: 3)
>   Failed tests:  6, 8-9
>   Non-zero exit status: 1
> t6050-replace.sh                                 (Wstat: 256 Tests: 28 Failed: 1)
>   Failed test:  15
>   Non-zero exit status: 1
> t1400-update-ref.sh                              (Wstat: 256 Tests: 133 Failed: 4)
>   Failed tests:  86-87, 130-131
>   Non-zero exit status: 1
> t5540-http-push-webdav.sh                        (Wstat: 256 Tests: 19 Failed: 2)
>   Failed tests:  8-9
>   Non-zero exit status: 1
> t5505-remote.sh                                  (Wstat: 256 Tests: 76 Failed: 5)
>   Failed tests:  11, 45-48
>   Non-zero exit status: 1
> t9903-bash-prompt.sh                             (Wstat: 256 Tests: 51 Failed: 1)
>   Failed test:  19
>   Non-zero exit status: 1
> t9300-fast-import.sh                             (Wstat: 256 Tests: 170 Failed: 1)
>   Failed test:  71
>   Non-zero exit status: 1
> t6030-bisect-porcelain.sh                        (Wstat: 256 Tests: 55 Failed: 47)
>   Failed tests:  2-5, 7-11, 13-14, 16-30, 32-34, 36-37, 39-44
>                 46-55
>   Non-zero exit status: 1
> t7512-status-help.sh                             (Wstat: 256 Tests: 35 Failed: 1)
>   Failed test:  27
>   Non-zero exit status: 1
> t5516-fetch-push.sh                              (Wstat: 256 Tests: 80 Failed: 3)
>   Failed tests:  47-49
>   Non-zero exit status: 1

Let me know if you need more information.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/