From: Karsten Blees Date: Wed, 18 Jun 2014 15:14:47 GMT Subject: Re: [PATCH v5 00/11] add performance tracing facility Message-ID: <53A1ACE7.2070601@gmail.com> In-Reply-To: Am 12.06.2014 20:30, schrieb Junio C Hamano: > Karsten Blees writes: > >> Here's v5 of the performance tracing patch series, now including a bunch of cleanups and adding timestamp, file and line to all trace output. >> >> I'm particularly interested in feedback for the output format. As file names have different lengths, printing file:line as prefix results in unaligned output: >> >> > GIT_TRACE=1 git stash list >> 00:12:10.544266 git.c:512 trace: exec: 'git-stash' 'list' >> 00:12:10.544266 run-command.c:337 trace: run_command: 'git-stash' 'list' >> 00:12:10.649779 git.c:312 trace: built-in: git 'rev-parse' '--git-dir' >> >> We could add separators to make it easier to parse, e.g.: >> >> > GIT_TRACE=1 git stash list >> [00:12:10.544266 git.c:512] trace: exec: 'git-stash' 'list' >> [00:12:10.544266 run-command.c:337] trace: run_command: 'git-stash' 'list' >> [00:12:10.649779 git.c:312] trace: built-in: git 'rev-parse' '--git-dir' > > This is easier to parse if " " and ":" are found in the names of > _our_ source files and "]" isn't, but is that really the case? > By "parsing" I actually meant the HumanEye (tm) parser, not lex/yacc and friends ("[]" just make nice recognizable separators). However, I think it shouldn't be too complicated to properly align the output, at least for the majority of 'short' file names in the git code base. E.g.: 00:12:10.544266 git.c:512 trace: exec: 'git-stash' 'list' 00:12:10.544266 run-command.c:337 trace: run_command: 'git-stash' 'list' 00:12:10.649779 git.c:312 trace: built-in: git 'rev-parse' '--git-dir' -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.