From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Fri, 13 Jun 2014 12:14:57 GMT
Subject: Re: [PATCHv2 5/6] t7510: test verify-commit
Message-ID: <539AEB41.6090306@drmicha.warpmail.net>
In-Reply-To: <20140613115125.GG14066@sigill.intra.peff.net>

Jeff King venit, vidit, dixit 13.06.2014 13:51:
> On Fri, Jun 13, 2014 at 12:42:47PM +0200, Michael J Gruber wrote:
> 
>>  test_expect_success GPG 'detect fudged signature' '
>>  	git cat-file commit master >raw &&
>>  
>>  	sed -e "s/seventh/7th forged/" raw >forged1 &&
>>  	git hash-object -w -t commit forged1 >forged1.commit &&
>> +	! git verify-commit $(cat forged1.commit) &&
> 
> Please use test_must_fail here (and further down), which will catch
> things like signal death.

Again, that is an issue of keeping the style of the surrounding code
(which is relatively new) vs. doing it differently. I don't mind
changing t7510 to a different style, though.

Michael