From: Johannes Sixt Date: Tue, 10 Jun 2014 06:04:15 GMT Subject: Re: [PATCH v7 0/1] refs.c: SSE4.2 optimizations for check_refname_component Message-ID: <53969FDF.3050506@viscovery.net> In-Reply-To: Am 6/10/2014 1:05, schrieb Junio C Hamano: > Junio C Hamano writes: > >> David Turner writes: >> >>> Since Junio has picked up the first patch from previous versions of >>> this series, I'm just going to send the second (SSE) one. I decided >>> not to s/NO_SSE42/!HAVE_SSE42/ because it looks like git mostly uses >>> the former convention (for instance, that's what GIT_PARSE_WITH >>> generates). >> >> Yeah but NO_FROTZ is used only when FROTZ is something everybody is >> expected to have (e.g. it's in posix, people ought to have it, but >> we do support those who don't), isn't it? For a very arch specific >> stuff like sse42, I'd feel better to make it purely opt-in by >> forcing people to explicitly say HAVE_SSE42 to enable it. > > Just FYI: I am getting > > compat/cpuid.h:8:12: error: 'processor_supports_sse42' defined but > not used [-Werror=unused-function] > cc1: all warnings being treated as errors > > while building 'pu'; I'll have to rebuild 'pu' without this patch > before I can push the day's result out. And I get this when I compile on Windows with msysgit: CC abspath.o In file included from git-compat-util.h:694, from cache.h:4, from abspath.c:1: compat/cpuid.h: In function 'processor_supports_sse42': compat/cpuid.h:11: warning: implicit declaration of function '__cpuid' abspath.c: At top level: compat/cpuid.h:8: warning: 'processor_supports_sse42' defined but not used abspath.c: In function 'processor_supports_sse42': compat/cpuid.h:11: warning: 'eax' is used uninitialized in this function compat/cpuid.h:11: warning: 'ebx' is used uninitialized in this function compat/cpuid.h:11: warning: 'ecx' is used uninitialized in this function compat/cpuid.h:11: warning: 'edx' is used uninitialized in this function Perhaps our gcc is too old? -- Hannes