From: Karsten Blees Date: Thu, 05 Jun 2014 22:12:12 GMT Subject: Re: Re: [PATCH] mingw: redefine the wrapper macro after the corresponding function Message-ID: <5390EB3C.1070202@gmail.com> In-Reply-To: <20140605151338.GA29385@camelia.ucw.cz> Am 05.06.2014 17:13, schrieb Stepan Kasal: > Hello Karsten, > > On Thu, Jun 05, 2014 at 04:51:39PM +0200, Karsten Blees wrote: >> In the current msysgit HEAD, most of these #undef's can simply be >> removed or have already been removed [...] > > not "most of." According to my quick count, 6 of 20 have been removed, > 2 more can be removed. The remaining 12 do play their role. > (The point you overlooked is that there are several socket related, > like bind().) > Right, premature generalization on my part from looking at the first two or so entries. However, I suspect some of the remaining 12 could be improved so that no #undef is necessary. E.g. gethostbyname could probably be implemented using GetAddrInfoW (supports non-ASCII names and IPv6). -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.