From: Karsten Blees Date: Fri, 23 May 2014 14:43:38 GMT Subject: Re: [RFC/PATCH v4 3/3] add command performance tracing to debug scripted commands Message-ID: <537F5E9A.1030901@gmail.com> In-Reply-To: <20140522095920.GA15461@sigill.intra.peff.net> Am 22.05.2014 11:59, schrieb Jeff King: > On Thu, May 22, 2014 at 02:40:48AM +0200, Karsten Blees wrote: > >> E.g. if I'm interested in a particular code section, I throw in 2 >> lines of code (before and after the code section). This gives very >> accurate results, without significantly affecting overall performance. >> I can then push the changes to my Linux/Windows box and get comparable >> results there. No need to disable optimization. No worries that the >> profiling tool isn't available on the other platform. No analyzing >> megabytes of mostly irrelevant profiling data. >> >> Does that make sense? > > Ah, I see. I misunderstood from your example above. > > I do agree that automatically stamping with __FILE__ and __LINE__ is > very helpful there. Could we maybe restrict that use of the variadic > macros to a few known-good compilers (maybe #ifdef __GNUC__, which also > hits clang, and something to catch MSVC)? On other systems it would > become a compile-time noop, and they could live without the feature. > > -Peff > Alright then. I've queued vor v5: * add __FILE__ __LINE__ for all trace output, if the compiler supports variadic macros * add timestamp for all trace output * perhaps move trace declarations to new trace.h * improve commit messages of existing patches to clarify the issues discussed so far I'm on holiday next week , so please be patient... -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.