From: Felipe Contreras Date: Fri, 09 May 2014 07:35:34 GMT Subject: Re: Conforming to pep8 Message-ID: <536c8546ed6fd_182dd0d3100@nysa.notmuch> In-Reply-To: <20140509072820.GD9051@wst420> William Giokas wrote: > On Fri, May 09, 2014 at 02:18:54AM -0500, Felipe Contreras wrote: > > William Giokas wrote: > > > On Thu, May 08, 2014 at 11:36:29PM -0500, Felipe Contreras wrote: > > > > William Giokas wrote: > > > > > E401: Multi-line imports seems like something that would just be > > > > > changing one line > > > > > > > > Yes, and make the code very annoying. > > > > > > It's 1 extra line in git-remote-hg, and 4 lines in git-remote-bzr. > > > > Ah, it refers to the '^import *' not '^from x import'. That's fine then. > > Yeah. In fact, for the mercurial stuff the `from mercurial import changegroup` > line should be on the same line as the other `from mercurial import ...` > line. I think the line is too big, it should be rearranged. But every time I add something to that list I say: I'll clean it up later =/ -- Felipe Contreras