From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Wed, 07 May 2014 19:01:29 GMT
Subject: Re: [PATCH 0/4] remote-hg: more improvements
Message-ID: <536a83097302f_76ff7a52ec6c@nysa.notmuch>
In-Reply-To: <xmqq8uqdbgqg.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > Here's a bunch of tests more, and a fixes for Mercurial v3.0.
> 
> I think the discussion with John Keeping hints that we shouldn't be
> rushing fc/remote-helpers-hg-bzr-graduation

Really? Based on what reasoning? I have proven his reasoning to be
basically wrong.

> I'll queue this separately on a topic based on the tip of
> yesterday's master for now.
> 
> One thing I couldn't read from the proposed log messages was if this
> is meant to work with and tested with both v3.0 and pre-v3.0 Hg, or
> this is to request others who run pre-v3.0 Hg to test these changes.
> 
> For example, I see
> 
> 	from mercurial import changegroup
>         if check_version(3, 0):
>         	cg = changegroup.getbundle(...)
> 	else:
>         	cg = repo.getbundle(...)
> 
> and offhand it was unclear if the unconditional import was a
> mistake.

Of course it wasn't a mistake.

-- 
Felipe Contreras