From: Karsten Blees <karsten.blees@gmail.com>
Date: Wed, 30 Apr 2014 08:35:56 GMT
Subject: Re: [PATCH 08/12] MINGW: fix main() signature in http-fetch.c and remote-curl.c
Message-ID: <5360B5EC.1070907@gmail.com>
In-Reply-To: <1398762726-22825-9-git-send-email-marat@slonopotamus.org>

Am 29.04.2014 11:12, schrieb Marat Radchenko:
> On MinGW, compat/mingw.h defines a 'mingw_main' wrapper function.
> Fix `warning: passing argument 2 of 'mingw_main' from incompatible
> pointer type` in http-fetch.c and remote-curl.c by dropping 'const'.
> 

Would you mind cross checking your changes with the msysgit fork? Fixing the same thing in a slightly different manner will just cause unnecessary conflicts (i.e. unnecessary work for the Git for Windows maintainers, as well as for you to come up with an alternate solution for something that's long been fixed).

See https://github.com/msysgit/git/commit/9206e7fd (squashed from https://github.com/msysgit/git/commit/0115ef83 and https://github.com/msysgit/git/commit/6949537a).