From: Torsten Bögershausen Date: Mon, 28 Apr 2014 19:59:39 GMT Subject: Re: [PATCH 03/12] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64 Message-ID: <535EB32B.4050209@web.de> In-Reply-To: <1398693097-24651-4-git-send-email-marat@slonopotamus.org> On 2014-04-28 15.51, Marat Radchenko wrote: > mingw-w64 has lseek defined in io.h. [] > #define off_t off64_t > +#ifndef lseek > #define lseek _lseeki64 > +#endif Is the commit message in line with the code? I would have expected something in this style: #if defined(__x86_64__) && ! defined(lseek)) #include #endif