From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Tue, 22 Apr 2014 06:56:33 GMT
Subject: Re: [RTC/PATCH] Add 'update-branch' hook
Message-ID: <535612a197c81_268bd0b3089a@nysa.notmuch>
In-Reply-To: <5356138D.9040409@gmail.com>

Ilya Bobyr wrote:
> On 4/21/2014 11:45 PM, Felipe Contreras wrote:
> > [...]
> >>>> This is how it is suggested by t/README and how it is done in the other
> >>>> test suites.
> >>>> I can not see how your case is different, but I might be missing something.
> >>> Let's take a cursoy look at `git grep -l "'EOF'" t`.
> >>>
> >>> [...]
> >> So the point is that some existing tests violate best practices?
> > I don't know what you mean by "best practices", but these are Git's best practices.
> 
> I am talking about recommendations in t/README that I quoted.

Those are *guidelines*, best practices are defined as things you actually do,
as in "actually practice".

-- 
Felipe Contreras