From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Wed, 16 Apr 2014 15:17:26 GMT
Subject: Re: [PATCH v3 16/25] commit_lock_file(): die() if called for unlocked lockfile object
Message-ID: <534E9F06.6010300@alum.mit.edu>
In-Reply-To: <534CD695.20306@viscovery.net>

On 04/15/2014 08:49 AM, Johannes Sixt wrote:
> Am 4/14/2014 15:54, schrieb Michael Haggerty:
>> diff --git a/lockfile.c b/lockfile.c
>> index 664b0c3..1453a7a 100644
>> --- a/lockfile.c
>> +++ b/lockfile.c
>> @@ -292,6 +292,9 @@ int commit_lock_file(struct lock_file *lk)
>>  	if (lk->fd >= 0 && close_lock_file(lk))
>>  		return -1;
>>  
>> +	if (!lk->filename[0])
>> +		die("BUG: attempt to commit unlocked object");
>> +
> 
> Shouldn't this be the first thing to check after entering the function?

You're right; I will change it.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/