From: Ronald Weiss <weiss.ronald@gmail.com>
Date: Sat, 12 Apr 2014 22:20:28 GMT
Subject: Re: [PATCH v3 2/2] commit: add --ignore-submodules[=<when>] parameter
Message-ID: <5349BC2C.9030509@gmail.com>
In-Reply-To: <53444368.9050607@web.de>

On 8. 4. 2014 20:43, Jens Lehmann wrote:
>> Useful <when> values for commit are 'all' (default) or 'none'. The others
>> ('dirty' and 'untracked') have same effect as 'none', as commit is only
>> interested in whether the submodule's HEAD differs from what is commited
>> in the superproject.
>
> Unless it outputs a status message, then 'dirty' and 'untracked' do
> influence what is shown there. Apart from that (and maybe tests for
> these two cases ;-) this is looking good to me.

OK, I updated the patch for commit to take that into account. Also, I
rebased both patches onto current master. Sending them in a moment.

If you don't have any more complaints, can I add "Acked-by: <you>" and
resend the patches to Junio?