From: Felipe Contreras Date: Thu, 10 Apr 2014 22:36:59 GMT Subject: Re: [PATCH v2 6/9] branch: display publish branch Message-ID: <53471d0b4c8dc_d696b12f08c@nysa.notmuch> In-Reply-To: Ramkumar Ramachandra wrote: > Felipe Contreras wrote: > > Signed-off-by: Felipe Contreras > > Please write a commit message, preferably showing the new git-branch output. Yeah... this has been sitting in git-fc for quite a while, I wasn't expecting to send this patch series again given that nobody commented on v1. > I noticed that this only picks up a publish-branch if > branch.*.pushremote is configured. What happened to the case when > remote.pushdefault is configured? What happens when branch.*.remote is not configured for @{upstream}? The same thing. It might be useful to visualize what would be the name of the branch when pushing it (without a refspec) even if the publish branch hasn't been configured, but I think the code would be much more coplicated, and it would break symetry with @{upstream}, besides, the user can just do 'git push -p branch', and from that moment on it will be visible. -- Felipe Contreras