From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Thu, 10 Apr 2014 22:27:07 GMT
Subject: Re: [PATCH v2 8/9] sha1_name: simplify track finding
Message-ID: <53471abb6fa76_d696b12f0b0@nysa.notmuch>
In-Reply-To: <CALkWK0kRAYpZxDkZ6nVPcfo4pqJuTLNFekpQ+tLPPRFJZKUMuw@mail.gmail.com>

Ramkumar Ramachandra wrote:
> Felipe Contreras wrote:
> > It's more efficient to check for the braces first.
> 
> Why is it more efficient? So you can error out quickly in the case of
> a malformed string?

That's one reason. The other is that get_sha1_basic() calls upstream_mark()
when we _already_ know there's a @{foo}.

-- 
Felipe Contreras