From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Sun, 06 Apr 2014 22:05:57 GMT
Subject: Re: [PATCH 18/22] lockfile: also keep track of the filename of the file being locked
Message-ID: <5341CFC5.6050904@alum.mit.edu>
In-Reply-To: <xmqq7g77wsxj.fsf@gitster.dls.corp.google.com>

On 04/02/2014 07:19 PM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>> This reduces the amount of string editing gyrations and makes it
>> unnecessary for callers to know how to derive the filename from the
>> lock_filename.
> 
> Hmph.
> 
> Is it worth duplicating the whole thing?  If you are planning to
> break the invariant lock_filename === filename + LOCK_SUFFIX in
> future changes in the series, it is understandable, though.

That is indeed the plan, but I'm splitting that change into a future
patch series because this one is getting big enough already dealing with
correctness issues.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/