From: René Scharfe <l.s.r@web.de>
Date: Mon, 24 Mar 2014 21:45:18 GMT
Subject: Re: [PATCH 03/10] t4209: factor out helper function test_log_icase()
Message-ID: <5330A76E.7060907@web.de>
In-Reply-To: <20140324211006.GA13728@sigill.intra.peff.net>

Am 24.03.2014 22:10, schrieb Jeff King:
> On Mon, Mar 24, 2014 at 11:22:30AM -0700, Junio C Hamano wrote:
>
>>> +test_log_icase() {
>>> +	test_log $@ --regexp-ignore-case
>>> +	test_log $@ -i
>>
>> &&-cascade broken?  Will squash in an obvious fix.
>
> I don't think so. This is happening outside of test_expect_success,
> which is run by test_log. So adding a && means that if the first test
> fails, we do not bother to run the second one at all, which is not what
> we want.

Right; this function runs two independent tests and && is left out 
intentionally.

René