From: Brad King <brad.king@kitware.com>
Date: Mon, 10 Mar 2014 17:12:14 GMT
Subject: Re: [PATCH 13/26] update-ref --stdin: Simplify error messages for missing oldvalues
Message-ID: <531DF26E.50806@kitware.com>
In-Reply-To: <531DF195.7020304@kitware.com>

On 03/10/2014 01:08 PM, Brad King wrote:
>> -		die("update %s missing [<oldvalue>] NUL", update->ref_name);
>> +		die("update %s missing <oldvalue>", update->ref_name);
> 
> The reason for the original wording is that the <oldvalue> is indeed
> optional.  This can only occur at end-of-input, and it is actually the
> *NUL* that is missing because an empty old value can be specified to
> mean that it it intentionally missing.

I see a following patch makes the wording even clearer about
unexpected end of input, so ignore my previous review.

-Brad