From: Dan Langille (dalangil) <dalangil@cisco.com>
Date: Tue, 06 Jan 2015 15:41:20 GMT
Subject: Re: [PATCH v2] remote-curl: fall back to Basic auth if Negotiate fails
Message-ID: <531A1350-22B9-4B64-BB8E-C627C545F4DA@cisco.com>
In-Reply-To: <3FBC0B0E-BB54-4BD5-AE7D-C82BA9FBA1C1@cisco.com>

> On Jan 6, 2015, at 10:31 AM, Dan Langille (dalangil) <dalangil@cisco.com> wrote:
> 
> On Jan 5, 2015, at 6:53 PM, brian m. carlson <sandals@crustytoothpaste.net> wrote:
>> 
>> On Mon, Jan 05, 2015 at 09:23:32PM +0000, Dan Langille (dalangil) wrote:
>>> I have tried both patches.  Neither succeeds here.  I patched git version 2.2.1 but I don’t think that affects this.
>> 
>> You are patching the client side, correct?  That's the side that needs patching here.
> 
> Yes, I am.
> 
>> Just so the list knows, I will be sending a reroll to the existing patch, but the patches I've posted do indeed work in my testing.
> 
> I appreciate the patches.  I blame something here.
> 
> The patches don’t t apply cleanly to git-2.2.1 or to the latest git source I just cloned.  I had to copy/paste some two chunks in http.c and everything in remote-curl.c.

NOTE: I now realize these problems are caused by tabs being converted to spaces when downloading the patch.  I’m going to test again.