From: Phil Lawrence Date: Mon, 09 Mar 2009 20:57:16 GMT Subject: Re: [PATCH] git-gui: Append ampersand to Target of lnk files created by do_cygwin_shortcut. Message-ID: <530ac78e0903091357v248895ack63588ae6e5e6b57a@mail.gmail.com> In-Reply-To: On Mon, Mar 9, 2009 at 3:13 PM, Johannes Schindelin wrote: > Hi, > > > > A few comments. > > Usually we try to use that subject as the subject of the mail, and we also > try to keep the subject shorter than 77 characters (so that "git log" on > an 80-column display does not need to wrap lines). > Also, we like authors to provide Signed-off-by: lines. OK, thank you. > Now, with the technical stuff out of the way: are you not changing > behavior? It seems that Linux users expect an program called by a menu > item to block the application until the program returns, so that an error > can be caught. The menu item in question is "Repository | Create Desktop Icon". It does not launch a program, but rather creates a shortcut (.lnk file) on the Windows desktop. The purpose of the created shortcut is to make it easy for a user to launch git-gui for a particular repo in the future. > Maybe the expectation is different on Windows? But then, we'd still like > to catch errors and warn the user about it, right? I believe a windows user would expect to see git gui launch when they click the shortcut; they would not expect (nor want) to see a cmd window open and remain open in the background. msysGit avoids opening a command window altogether when it's Git GUI shortcut is used. Ideally git on cygwin would also have shortcuts that simply open the GUI, but as a first step I saw we could at least make the command window politely disappear. Phil Lawrence