From: Patrick Steinhardt Date: Mon, 16 Sep 2024 11:45:41 GMT Subject: [PATCH 06/23] builtin/submodule--helper: fix leaking error buffer Message-ID: <52d12e034b8104a0283958ada013b028322ce421.1726484308.git.ps@pks.im> In-Reply-To: Fix leaking error buffer when `compute_alternate_path()` fails. Signed-off-by: Patrick Steinhardt --- builtin/submodule--helper.c | 2 ++ t/t7408-submodule-reference.sh | 2 ++ 2 files changed, 4 insertions(+) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index fd1b6794083..ff1376f69fc 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -1621,6 +1621,8 @@ static int add_possible_reference_from_superproject( ; /* nothing */ } } + + strbuf_release(&err); strbuf_release(&sb); } diff --git a/t/t7408-submodule-reference.sh b/t/t7408-submodule-reference.sh index d6040e0a337..7e1afa9ce47 100755 --- a/t/t7408-submodule-reference.sh +++ b/t/t7408-submodule-reference.sh @@ -4,6 +4,8 @@ # test_description='test clone --reference' + +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh base_dir=$(pwd) -- 2.46.0.551.gc5ee8f2d1c.dirty