From: Torsten Bögershausen <tboegi@web.de>
Date: Sun, 02 Feb 2014 12:27:25 GMT
Subject: Re: [PATCH v4 3/4] setup: Add 'abspath_part_inside_repo' function
Message-ID: <52EE39AD.80801@web.de>
In-Reply-To: <20140202120943.GA27787@mule>

> 
>> Another comment:
>> The "raw" comparison with '/' is probably working well on all
>> POSIX/Linux/Unix systems.
>>
>> To be more portable, the macro
>> is_dir_sep()
>> can be used:
>>
>> if (is_dir_sep(path[wtlen]))
> 
> Since the path is already normalized by 'normalize_path_copy_len' which
> seems to guarantee '/'-separation, I have assumed that this was
> unnecessary?

So true, sorry for the noise.