From: Derrick Stolee Date: Mon, 21 Oct 2019 12:08:58 GMT Subject: Re: [PATCH v4 00/17] New sparse-checkout builtin and "cone" mode Message-ID: <529d7656-d9d9-1a52-cea5-132ac8fdd2f7@gmail.com> In-Reply-To: <1ea216d8-e706-ec4c-a3f3-954e57e0458c@jonsimons.org> On 10/17/2019 7:53 PM, Jon Simons wrote: > On 10/15/19 6:55 AM, Derrick Stolee via GitGitGadget wrote: >> V4 UPDATE: Rebased on latest master to include ew/hashmap and >> ds/include-exclude in the base. > > I did a partial review of the v4 patches out of curiosity and I notice > in sparse-checkout.c there are a couple of unchecked `fopen` call sites > that could be converted to `xfopen` to die gracefully upon error, and > one unchecked `fdopen` that can likewise be `xfdopen`. Thanks! Fixed for v5. -Stolee