From: Andrés G. Aragoneses <knocte@gmail.com>
Date: Mon, 18 Nov 2013 22:45:11 GMT
Subject: [PATCHv2] transport: Catch non positive --depth option value
Message-ID: <528A9877.4060802@gmail.com>
In-Reply-To: <xmqqzjp1bqm3.fsf@gitster.dls.corp.google.com>

Instead of simply ignoring the value passed to --depth
option when it is zero or negative, now it is caught
and reported.

This will let people know that they were using the
option incorrectly (as depth<0 should be simply invalid,
and under the hood depth==0 didn't have any effect).

Signed-off-by: Andres G. Aragoneses <knocte@gmail.com>
Reviewed-by: Duy Nguyen <pclouds@gmail.com>
Reviewed-by: Junio C Hamano <gitster@pobox.com>
---
  transport.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/transport.c b/transport.c
index 7202b77..edd63eb 100644
--- a/transport.c
+++ b/transport.c
@@ -483,6 +483,8 @@ static int set_git_option(struct 
git_transport_options *opts,
              opts->depth = strtol(value, &end, 0);
              if (*end)
                  die("transport: invalid depth option '%s'", value);
+            if (opts->depth < 1)
+                die("transport: invalid depth option '%s' (non 
positive)", value);
          }
          return 0;
      }
-- 
1.8.1.2