From: Kristoffer Haugsbakk Date: Tue, 03 Nov 2026 10:45:51 GMT Subject: Re: [PATCH v2 0/5] format-rev: add --abbrev, --color, and --date Message-ID: <528139f6-db92-4061-be0a-88d4c376d252@app.fastmail.com> In-Reply-To: <2A1E1423-8C1B-48FA-B1BD-DBD422748623@gmail.com> On Mon, Nov 2, 2026, at 17:49, Ben Knoble wrote: >> Le 2 nov. 2026 à 05:51, Kristoffer Haugsbakk a écrit : >> >> On Mon, Nov 2, 2026, at 09:51, Junio C Hamano wrote: >>> Junio C Hamano writes: >>> >>>[snip] >>> >>> Second call. Anybody? >>> >>> Unless we see some volunteers to give it a review in a few weeks, I >>> will discard the topic out of my tree, as 'seen' has been crowded >>> with topics that have been collecting dust without getting many >>> reviews. > > Sorry for not getting to it :/ > >> For you all’s information, what was originally totally unrelated >> research has made me doubt whether this command is needed.[1] >> git-diff-tree(1) cannot do what this command does right out of the box, >> but it looks like some modifications can make it a replacement for `git >> format-rev --stdin-mode=revs`.[2] > > I saw these come through, and I’m not sure where you landed. That git-diff-tree(1) just needs to learn to optionally NUL-terminate diff and log output.[1] I looked into it after that and the code has turned out to be too difficult for me to make sense of. [1] <238e5652-e95b-4d44-a900-e16aa6ab81f0@app.fastmail.com>; https://lore.kernel.org/git/238e5652-e95b-4d44-a900-e16aa6ab81f0@app.fastmail.com/ > I was mostly interested in the stdin filter mode that turns hashes > into references; is that supported by your alternative? No it’s not. `git format-rev --stdin-mode=text` still has its niche. >> [1]: ; >> https://lore.kernel.org/git/ce69d94e-7329-449d-b3c3-47d4f3aa608c@app.fastmail.com/ >> [2]: <238e5652-e95b-4d44-a900-e16aa6ab81f0@app.fastmail.com>; >> https://lore.kernel.org/git/238e5652-e95b-4d44-a900-e16aa6ab81f0@app.fastmail.com/