From: Karsten Blees <karsten.blees@gmail.com>
Date: Fri, 08 Nov 2013 10:27:34 GMT
Subject: Re: [PATCH v4 13/14] builtin/update-index.c: cleanup update_one
Message-ID: <527CBC96.2090101@gmail.com>
In-Reply-To: <xmqqwqkjq49v.fsf@gitster.dls.corp.google.com>

Am 07.11.2013 22:40, schrieb Junio C Hamano:
> Karsten Blees <karsten.blees@gmail.com> writes:
> 
>> -			if (p < path || p > path + strlen(path))
>> -				free((char *)p);
>> +			free(p);
> 
> The non-const cast was there for a reason.  I'll locally fix it up
> (there is another instance of the same) to get it compile before
> queuing it on 'pu'.
> 
> Thanks.
> 

Seems I spent too much time on code analysis and valgrind results that I missed the compiler warnings...didn't we have -Werror once?