From: Johannes Sixt <j.sixt@viscovery.net>
Date: Fri, 25 Oct 2013 08:17:03 GMT
Subject: Re: [PATCH v2 2/2] merge-base: "--reflog" mode finds fork point from reflog entries
Message-ID: <526A28FF.4000207@viscovery.net>
In-Reply-To: <20131025080923.GG10779@serenity.lan>

Am 10/25/2013 10:09, schrieb John Keeping:
> On Fri, Oct 25, 2013 at 09:12:10AM +0200, Johannes Sixt wrote:
>> You could put the loops into a function from which you 'return', but that
>> is obscure in this case. The first iteration was better, IMO.
> 
> Wouldn't it be simpler to just return from the test?  That is, replace
> the "break" in the above patch with "return 1".

Good catch! We explicitly have

test_eval_ () {
	# This is a separate function because some tests use
	# "return" to end a test_expect_success block early.
	eval </dev/null >&3 2>&4 "$*"
}

to protect this use of return.

-- Hannes