From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Mon, 23 Sep 2013 02:35:10 GMT
Subject: Re: [PATCH 4/9] fast-export: add new --refspec option
Message-ID: <523fa8de6a048_57ae47e7441437@nysa.mail>
In-Reply-To: <523FA07C.9040909@bbn.com>

Richard Hansen wrote:
> On 2013-08-29 11:23, Felipe Contreras wrote:
> > So that we can covert the exported ref names.
> > 
> > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> > ---
> >  Documentation/git-fast-export.txt |  4 ++++
> >  builtin/fast-export.c             | 30 ++++++++++++++++++++++++++++++
> >  t/t9350-fast-export.sh            |  7 +++++++
> >  3 files changed, 41 insertions(+)
> > 
> > diff --git a/Documentation/git-fast-export.txt b/Documentation/git-fast-export.txt
> > index 85f1f30..221506b 100644
> > --- a/Documentation/git-fast-export.txt
> > +++ b/Documentation/git-fast-export.txt
> > @@ -105,6 +105,10 @@ marks the same across runs.
> >  	in the commit (as opposed to just listing the files which are
> >  	different from the commit's first parent).
> >  
> > +--refspec::
> > +	Apply the specified refspec to each ref exported. Multiple of them can
> > +	be specified.
> > +
> 
> Do you mean '--refspec=<refspec>' and/or '--refspec <refspec>'?

I mean --refspec refspec1 --refspec refspec2.

> > diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh
> > index 34c2d8f..dc6666f 100755
> > --- a/t/t9350-fast-export.sh
> > +++ b/t/t9350-fast-export.sh
> > @@ -504,4 +504,11 @@ test_expect_success 'refs are updated even if no commits need to be exported' '
> >  	test_cmp expected actual
> >  '
> >  
> > +test_expect_success 'use refspec' '
> > +	git fast-export --refspec refs/heads/master:refs/heads/foobar master | \
> > +		grep "^commit " | sort | uniq > actual &&
> > +	echo "commit refs/heads/foobar" > expected &&
> > +	test_cmp expected actual
> > +'
> > +
> >  test_done
> > 
> 
> I think it'd be good to add a test for multiple refspecs.

Maybe. If these patches were to actually be applied.

-- 
Felipe Contreras